Force show tooltip D&D off

apache · Aug 6, 2021 · 2398c7b · 2398c7b
1 parent 48fcdfa
commit 2398c7b
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 8 deletions.
diff --git a/superset-frontend/src/explore/components/controls/DndColumnSelectControl/OptionWrapper.tsx b/superset-frontend/src/explore/components/controls/DndColumnSelectControl/OptionWrapper.tsx
@@ -122,10 +122,7 @@ export default function OptionWrapper(
   });
 
   const shouldShowTooltip =
-    (!isDragging &&
-      tooltipTitle &&
-      label &&
-      tooltipTitle.length > label.length) ||
+    (!isDragging && tooltipTitle && label && tooltipTitle !== label) ||
     (!isDragging &&
       labelRef &&
       labelRef.current &&

diff --git a/superset-frontend/src/explore/components/controls/OptionControls/index.tsx b/superset-frontend/src/explore/components/controls/OptionControls/index.tsx
@@ -261,10 +261,15 @@ export const OptionControlLabel = ({
 
   const getLabelContent = () => {
     const shouldShowTooltip =
-      !isDragging &&
-      labelRef &&
-      labelRef.current &&
-      labelRef.current.scrollWidth > labelRef.current.clientWidth;
+      (!isDragging &&
+        typeof label === 'string' &&
+        tooltipTitle &&
+        label &&
+        tooltipTitle !== label) ||
+      (!isDragging &&
+        labelRef &&
+        labelRef.current &&
+        labelRef.current.scrollWidth > labelRef.current.clientWidth);
 
     if (savedMetric && hasMetricName) {
       return (