Merge pull request #4991 from michellethomas/fix_filter_blank_custom_sql

[Bugfix] Allowing sqlExpression to be blank
apache · May 14, 2018 · 071c6a6 · 071c6a6
2 parents 2c5200a + ad4912d
commit 071c6a6
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/superset/assets/src/explore/AdhocFilter.js b/superset/assets/src/explore/AdhocFilter.js
@@ -45,7 +45,8 @@ export default class AdhocFilter {
       this.clause = adhocFilter.clause;
       this.sqlExpression = null;
     } else if (this.expressionType === EXPRESSION_TYPES.SQL) {
-      this.sqlExpression = adhocFilter.sqlExpression ||
+      this.sqlExpression = typeof adhocFilter.sqlExpression === 'string' ?
+        adhocFilter.sqlExpression :
         translateToSql(adhocFilter, { useSimple: true });
       this.clause = adhocFilter.clause;
       this.subject = null;