Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-49254][BUILD] Upgrade mima-core & sbt-mima-plugin to 1.1.4 #47780

Closed
wants to merge 1 commit into from

Conversation

panbingkun
Copy link
Contributor

@panbingkun panbingkun commented Aug 16, 2024

What changes were proposed in this pull request?

The pr aims to upgrade mima-core & sbt-mima-plugin from 1.1.3 to 1.1.4.

Why are the changes needed?

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Pass GA.

Was this patch authored or co-authored using generative AI tooling?

No.

@github-actions github-actions bot added the BUILD label Aug 16, 2024
@panbingkun panbingkun marked this pull request as ready for review August 16, 2024 02:26
@panbingkun
Copy link
Contributor Author

cc @LuciferYang @dongjoon-hyun

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @panbingkun .

+1, LGTM. (Pending CIs).

@dongjoon-hyun
Copy link
Member

Merged to master. Thank you, @panbingkun and @LuciferYang .

IvanK-db pushed a commit to IvanK-db/spark that referenced this pull request Sep 20, 2024
### What changes were proposed in this pull request?
The pr aims to upgrade `mima-core` & `sbt-mima-plugin` from `1.1.3` to `1.1.4`.

### Why are the changes needed?
- The full release notes:
  https://github.com/lightbend/mima/releases/tag/1.1.4

- This version adapts to `scala-2.13.14`, which is also used by Spark currently
  Update scala-library, scala-reflect to 2.13.14 by scala-steward in lightbend-labs/mima#809

### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?
Pass GA.

### Was this patch authored or co-authored using generative AI tooling?
No.

Closes apache#47780 from panbingkun/SPARK-49254.

Authored-by: panbingkun <panbingkun@baidu.com>
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants