Provide raw counters metrics (#5735) #5802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sijie
approved these changes
Dec 8, 2019
sijie
reviewed
Dec 8, 2019
| category = CATEGORY_METRICS, | ||
| doc = "If true, export raw counter topic level metrics" | ||
| ) | ||
| private boolean exposeCounterTopicMetricsInPrometheus = false; |
There was a problem hiding this comment.
I don't think we need this flag.
if exposeTopicLevelMetricsInPrometheus is true, we can expose this counter. there should be no penalty to do so.
There was a problem hiding this comment.
Agree with your point of view
There was a problem hiding this comment.
Right, doing the modifications
codelipenghui
approved these changes
Dec 11, 2019
|
run java8 tests |
|
run cpp tests |
|
Thanks! |
jiazhai
pushed a commit
that referenced
this pull request
May 12, 2020
cdbartholomew
pushed a commit
to kafkaesque-io/pulsar
that referenced
this pull request
May 23, 2020
…pace/subscription/consumer. (apache#6918) Fixes apache#6891 Rated to apache#5802 Add pulsar_out_bytes_total and pulsar_out_messages_total for namespace/subscription/consumer. New unit test added.
Huanli-Meng
pushed a commit
to Huanli-Meng/pulsar
that referenced
this pull request
May 27, 2020
…pace/subscription/consumer. (apache#6918) Fixes apache#6891 Rated to apache#5802 ### Motivation Add pulsar_out_bytes_total and pulsar_out_messages_total for namespace/subscription/consumer. ### Verifying this change New unit test added.
addisonj
pushed a commit
to instructure/pulsar
that referenced
this pull request
Jun 12, 2020
…pace/subscription/consumer. (apache#6918) Fixes apache#6891 Rated to apache#5802 Add pulsar_out_bytes_total and pulsar_out_messages_total for namespace/subscription/consumer. New unit test added. (cherry picked from commit 204f327)
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
…pace/subscription/consumer. (apache#6918) Fixes apache#6891 Rated to apache#5802 ### Motivation Add pulsar_out_bytes_total and pulsar_out_messages_total for namespace/subscription/consumer. ### Verifying this change New unit test added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(If this PR fixes a github issue, please add
Fixes #<xyz>.)Fixes #5735
Motivation
Add counter based metrics for topics.
Modifications
Added counter on AbstractTopics and propagate the result to the PrometheusHandler.
Verifying this change
Added a test
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation