Synchronized producer cleanup during close operation #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes apache#33: Intermittent test failure on BacklogQuotaManagerTest.testAheadProducerOnHoldTimeout
|
CLA is valid! |
2 similar comments
|
CLA is valid! |
|
CLA is valid! |
|
👍 |
sboobna
approved these changes
Sep 22, 2016
belinda-wong
added a commit
to belinda-wong/pulsar
that referenced
this pull request
Nov 28, 2019
Fix the link issue apache#34 see ["Enabling TLS Authentication on Proxies"](security-tls-authentication.md#on-proxies)
massakam
pushed a commit
to massakam/pulsar
that referenced
this pull request
Aug 6, 2020
…xamples Add subscription type to examples.
hangc0276
pushed a commit
to hangc0276/pulsar
that referenced
this pull request
May 26, 2021
2 tasks
tisonkun
pushed a commit
to tisonkun/pulsar
that referenced
this pull request
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There is a race condition between producer send timeout and producer instance getting closed that might result in message buffers being released twice.
The symptoms are visible in #33
Modifications
Synchronize the cleanup of the pending messages queue when closing the producer.