[fix][broker] Fix retry backoff for PersistentDispatcherMultipleConsumers #23284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erMultipleConsumers
lhotari
force-pushed
the
lh-fix-invalid-lastNumberOfEntriesDispatched
branch
from
ad68d86
to
49d1190
Compare
Merged
4 tasks
coderzc
previously approved these changes
Sep 11, 2024
lhotari
changed the title
coderzc
approved these changes
Sep 11, 2024
mattisonchao
approved these changes
Sep 11, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #23284 +/- ##
============================================
+ Coverage 73.57% 74.50% +0.93%
- Complexity 32624 33761 +1137
============================================
Files 1877 1926 +49
Lines 139502 145040 +5538
Branches 15299 15857 +558
============================================
+ Hits 102638 108062 +5424
+ Misses 28908 28697 -211
- Partials 7956 8281 +325
Flags with carried forward coverage won't be shown. Click here to find out more.
|
michalcukierman
pushed a commit
to michalcukierman/pulsar
that referenced
this pull request
Sep 11, 2024
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Sep 12, 2024
…mers (apache#23284) (cherry picked from commit 8151639) (cherry picked from commit d9598b5)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Sep 12, 2024
…mers (apache#23284) (cherry picked from commit 8151639) (cherry picked from commit d9598b5)
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#23226 introduced a regression since the test coverage was missing for PersistentDispatcherMultipleConsumers.
It causes a performance regression since a backoff is introduced for all calls.
Modifications
Documentation
docdoc-requireddoc-not-neededdoc-complete