[improve][broker] Add retry for start service unit state channel (ExtensibleLoadManagerImpl only) #23230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heesung-sn
reviewed
Aug 27, 2024
...r-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/ModularLoadManagerImpl.java
Outdated
Show resolved
Hide resolved
heesung-sn
approved these changes
Aug 27, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #23230 +/- ##
============================================
+ Coverage 73.57% 74.48% +0.91%
- Complexity 32624 33684 +1060
============================================
Files 1877 1922 +45
Lines 139502 144784 +5282
Branches 15299 15837 +538
============================================
+ Hits 102638 107842 +5204
+ Misses 28908 28673 -235
- Partials 7956 8269 +313
Flags with carried forward coverage won't be shown. Click here to find out more.
|
lhotari
reviewed
Aug 29, 2024
...src/main/java/org/apache/pulsar/broker/loadbalance/extensions/ExtensibleLoadManagerImpl.java
Outdated
Show resolved
Hide resolved
lhotari
reviewed
Aug 30, 2024
...src/main/java/org/apache/pulsar/broker/loadbalance/extensions/ExtensibleLoadManagerImpl.java
Show resolved
Hide resolved
Demogorgon314
commented
Aug 30, 2024
...src/main/java/org/apache/pulsar/broker/loadbalance/extensions/ExtensibleLoadManagerImpl.java
Show resolved
Hide resolved
RobertIndie
reviewed
Sep 2, 2024
...src/main/java/org/apache/pulsar/broker/loadbalance/extensions/ExtensibleLoadManagerImpl.java
Outdated
Show resolved
Hide resolved
gaoran10
reviewed
Sep 3, 2024
...src/main/java/org/apache/pulsar/broker/loadbalance/extensions/ExtensibleLoadManagerImpl.java
Show resolved
Hide resolved
gaoran10
approved these changes
Sep 4, 2024
|
Let me merge it since there is no new response from @lhotari. Please open a new PR if you found something wrong. |
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Sep 10, 2024
…ensibleLoadManagerImpl only) (apache#23230) (cherry picked from commit 8bb30a1) (cherry picked from commit 97fad78)
michalcukierman
pushed a commit
to michalcukierman/pulsar
that referenced
this pull request
Sep 11, 2024
…ensibleLoadManagerImpl only) (apache#23230)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Sep 12, 2024
…ensibleLoadManagerImpl only) (apache#23230) (cherry picked from commit 8bb30a1) (cherry picked from commit 97fad78)
BewareMyPower
added a commit
to BewareMyPower/pulsar
that referenced
this pull request
Sep 12, 2024
…nel (ExtensibleLoadManagerImpl only) (apache#23230)" This reverts commit 8bb30a1.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When the service unit state channel fails to start, it will throw an exception, and after the PR #22977 , it will fail forever, because the pulsar broker cannot catch the exception, and it won't have any retry mechanism
Modifications
Add retry for start service unit state channel
Documentation
docdoc-requireddoc-not-neededdoc-complete