[cleanup][broker] delete ConcurrentSortedLongPairSet. #23202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thetumbled
requested review from
codelipenghui,
BewareMyPower,
nodece and
dao-jun
|
I start a discussion at https://lists.apache.org/thread/s2fwcswtkym6x5klf2wsn3zphhlqn18o, feel free to leave comments if you have any concern. |
lhotari
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #23202 +/- ##
============================================
+ Coverage 73.57% 74.54% +0.97%
- Complexity 32624 34133 +1509
============================================
Files 1877 1920 +43
Lines 139502 144436 +4934
Branches 15299 15813 +514
============================================
+ Hits 102638 107671 +5033
+ Misses 28908 28512 -396
- Partials 7956 8253 +297
Flags with carried forward coverage won't be shown. Click here to find out more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
ConcurrentSortedLongPairSethas been replaced byConcurrentBitmapSortedLongPairSetin #17804 since version 2.9.x, and there is no usage of it anymore.Modifications
Delete it safely.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: