New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jacoco - Codecov.io integration #14600

Closed

nicoloboschi wants to merge 2 commits into apache:master from nicoloboschi:feat/jacoco-jcodecov

Contributor

nicoloboschi commented Mar 8, 2022

Motivation

Jacoco is configured but it does not give an holistic view about Pulsar codebase code coverage.
codecov.io is a free tool that aggregate multiple jacoco file reports.

Goals:

Give an idea of the Pulsar codebase less covered by tests
Ensure new PR will not lower the code coverage percentage (or at least make it visible to reviewers)

Modifications

All the unit tests CI jobs now run with the additional profile coverage which enables the Jacoco plugin
New Github Actions which upload the Jacoco reports to codecov.io service

I have a concern about that it is possible that Jacoco adds a certain overhead to the tests execution (increased memory usage?) but, if the all the CI is passing, I'm confident this is not a problem for the Pulsar codebase

Note:

We need to enable the CodeCov app to the Pulsar project
Integration tests coverage are not included in this PR. We can work on it later on.

no-need-doc

github-actions bot assigned nicoloboschi

github-actions bot added the doc-not-needed label

codecov-commenter commented Mar 8, 2022 •

edited

Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@d3f6fe3). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #14600   +/-   ##
=========================================
  Coverage          ?   52.09%           
  Complexity        ?    17501           
=========================================
  Files             ?     1405           
  Lines             ?   118135           
  Branches          ?    13651           
=========================================
  Hits              ?    61547           
  Misses            ?    50962           
  Partials          ?     5626

Flag	Coverage Δ
unittests	`52.09% <0.00%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3f6fe3...0fa212d. Read the comment docs.

Contributor Author

nicoloboschi commented Mar 8, 2022

/pulsarbot rerun-failure-checks

lhotari reviewed

View reviewed changes

build/run_unit_group.sh Outdated Show resolved Hide resolved

Member

lhotari commented Mar 8, 2022

Very cool to see the coverage reports.

Contributor Author

nicoloboschi commented Mar 10, 2022

/pulsarbot rerun-failure-checks

nicoloboschi closed this

nicoloboschi reopened this

Contributor Author

nicoloboschi commented Mar 12, 2022

/pulsarbot rerun-failure-checks

nicoloboschi marked this pull request as ready for review

March 16, 2022 15:46

dlg99 approved these changes

View reviewed changes

eolivelli approved these changes

View reviewed changes

Contributor

eolivelli left a comment

Great stuff

Contributor Author

nicoloboschi commented Mar 25, 2022

@codelipenghui @merlimat PTAL

nicoloboschi force-pushed the feat/jacoco-jcodecov branch from 0fa212d to 987bda1 Compare

March 30, 2022 22:07

nicoloboschi closed this

nicoloboschi reopened this

nicoloboschi closed this

nicoloboschi reopened this

Contributor Author

nicoloboschi commented Apr 1, 2022

/pulsarbot rerun-failure-checks

nicoloboschi force-pushed the feat/jacoco-jcodecov branch from 987bda1 to 7b38eaf Compare

April 4, 2022 18:12

nicoloboschi closed this

nicoloboschi reopened this

Contributor Author

nicoloboschi commented Apr 14, 2022

@lhotari @merlimat @codelipenghui time to merge it? 🤞

github-actions bot commented May 15, 2022

The pr had no activity for 30 days, mark with Stale label.

github-actions bot added the lifecycle/stale label

Contributor Author

nicoloboschi commented May 17, 2022

/pulsarbot rerun-failure-checks

nicoloboschi force-pushed the feat/jacoco-jcodecov branch from 7b38eaf to 51e3f2a Compare

May 17, 2022 13:55

github-actions bot removed the lifecycle/stale label


          Jacoco - Codecov.io integration

6342ffc


          revert BlobStoreManagedLedgerOffloaderTest

nicoloboschi force-pushed the feat/jacoco-jcodecov branch from 51e3f2a to 5934300 Compare

June 6, 2022 11:47

Contributor Author

nicoloboschi commented Jun 7, 2022

/pulsarbot rerun-failure-checks

github-actions bot commented Jul 8, 2022

The pr had no activity for 30 days, mark with Stale label.

github-actions bot added the Stale label

Demogorgon314 approved these changes

View reviewed changes

Contributor

yaalsn commented Jul 27, 2022

@lhotari I can't find any workflow of New Github Actions which upload the Jacoco reports to codecov.io service in this pr, could you point it to me?

github-actions bot removed the Stale label

nicoloboschi closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels