Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIP 81: Split the individual acknowledgments into multiple entries #10729

Closed
wants to merge 22 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions conf/broker.conf
Original file line number Diff line number Diff line change
Expand Up @@ -950,6 +950,13 @@ managedLedgerMaxUnackedRangesToPersist=10000
# zookeeper.
managedLedgerMaxUnackedRangesToPersistInZooKeeper=1000

# If enabled, the maximum "acknowledgment holes" will not be limited.
# Only part of hotspot data will keep in memory by using LRU.
enableLruCacheMaxUnackedRanges=false

# Max Bytes of UnackedRanges can keep in memory.
maxUnackedRangesInMemoryBytes=3145728

# Skip reading non-recoverable/unreadable data-ledger under managed-ledger's list. It helps when data-ledgers gets
# corrupted at bookkeeper and managed-cursor is stuck at that ledger.
autoSkipNonRecoverableData=false
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,8 @@ public class ManagedLedgerConfig {
private boolean createIfMissing = true;
private int maxUnackedRangesToPersist = 10000;
private int maxBatchDeletedIndexToPersist = 10000;
private boolean enableLruCacheMaxUnackedRanges = false;
private long maxUnackedRangesInMemoryBytes = 3145728;
private boolean deletionAtBatchIndexLevelEnabled = true;
private int maxUnackedRangesToPersistInZk = 1000;
private int maxEntriesPerLedger = 50000;
Expand Down Expand Up @@ -488,6 +490,24 @@ public void setMaxUnackedRangesToPersistInZk(int maxUnackedRangesToPersistInZk)
this.maxUnackedRangesToPersistInZk = maxUnackedRangesToPersistInZk;
}

public boolean isEnableLruCacheMaxUnackedRanges() {
return enableLruCacheMaxUnackedRanges;
}

public ManagedLedgerConfig setEnableLruCacheMaxUnackedRanges(boolean enableLruCacheMaxUnackedRanges) {
this.enableLruCacheMaxUnackedRanges = enableLruCacheMaxUnackedRanges;
return this;
}

public long getMaxUnackedRangesInMemoryBytes() {
return maxUnackedRangesInMemoryBytes;
}

public ManagedLedgerConfig setMaxUnackedRangesInMemoryBytes(long maxUnackedRangesInMemoryBytes) {
this.maxUnackedRangesInMemoryBytes = maxUnackedRangesInMemoryBytes;
return this;
}

/**
* Get ledger offloader which will be used to offload ledgers to longterm storage.
*
Expand Down

Large diffs are not rendered by default.

Loading