resolved comment

apache · Sep 18, 2024 · 7faccbb · 7faccbb
1 parent 04158a7
commit 7faccbb
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/.../apache/pulsar/broker/loadbalance/extensions/channel/ServiceUnitStateTableViewSyncer.java b/.../apache/pulsar/broker/loadbalance/extensions/channel/ServiceUnitStateTableViewSyncer.java
@@ -43,6 +43,7 @@
 @Slf4j
 public class ServiceUnitStateTableViewSyncer implements Closeable {
     private static final int MAX_CONCURRENT_SYNC_COUNT = 100;
+    private static final int MAX_SYNC_WAIT_TIME_IN_SECS = 300;
     private volatile ServiceUnitStateTableView systemTopicTableView;
     private volatile ServiceUnitStateTableView metadataStoreTableView;
     private volatile boolean isActive = false;
@@ -116,14 +117,14 @@ public void start(PulsarService pulsar)
             futures.clear();
 
             int size = merged.size();
-            int syncTimeout = opTimeout * size;
             while (metadataStoreTableView.entrySet().size() != size || systemTopicTableView.entrySet().size() != size) {
-                if (TimeUnit.MILLISECONDS.toSeconds(System.currentTimeMillis() - started) > syncTimeout) {
+                if (TimeUnit.MILLISECONDS.toSeconds(System.currentTimeMillis() - started)
+                        > MAX_SYNC_WAIT_TIME_IN_SECS) {
                     throw new TimeoutException(
                             "Failed to sync tableviews. MetadataStoreTableView.size: "
                                     + metadataStoreTableView.entrySet().size()
                                     + ", SystemTopicTableView.size: " + systemTopicTableView.entrySet().size() + " in "
-                                    + syncTimeout + " secs");
+                                    + MAX_SYNC_WAIT_TIME_IN_SECS + " secs");
                 }
                 Thread.sleep(100);
             }
@@ -144,7 +145,7 @@ private CompletableFuture<Void> syncToSystemTopic(String key, ServiceUnitStateDa
         return systemTopicTableView.put(key, data);
     }
 
-    private CompletableFuture<Void>  syncToMetadataStore(String key, ServiceUnitStateData data) {
+    private CompletableFuture<Void> syncToMetadataStore(String key, ServiceUnitStateData data) {
         return metadataStoreTableView.put(key, data);
     }