read module version info from golang runtime #856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgier
force-pushed
the
embed-module-version
branch
4 times, most recently
from
074a85d
to
e4259ed
Compare
merlimat
approved these changes
Sep 30, 2022
nodece
approved these changes
Oct 1, 2022
Instead of maintaining a hard coded version string in the sources, we can get the version of the pulsar-client-go module used to build the client application. Signed-off-by: Paul Gier <paul.gier@datastax.com>
pgier
force-pushed
the
embed-module-version
branch
from
e4259ed
to
a915106
Compare
Signed-off-by: Paul Gier <paul.gier@datastax.com>
|
@merlimat I agree it would be good to have a test like that, but it's a little difficult to set up because in order to have a module version, we would need to import this module from another module, but then we can't access the Version variable, because it's in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Instead of maintaining a hard coded version string in the sources, we can get the version of the pulsar-client-go module used to build the client application.
Modifications
Removed the hard coded version string and replaced it with code that runs at initialization to look up the version of the client golang module dependency that was used to build the app.
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.