-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce doneCh for ack error #777
Conversation
Signed-off-by: xiaolongran <xiaolongran@tencent.com>
Signed-off-by: xiaolongran <xiaolongran@tencent.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if deleting A was the right choice.
Signed-off-by: xiaolongran <xiaolongran@tencent.com>
@freeznet PTAL thanks |
Signed-off-by: xiaolongran <xiaolongran@tencent.com>
hi @wolfstudy , what would happen if currently we don't wait for ACK but broker side failed to ack? |
Here we can look at two situations:
|
Signed-off-by: xiaolongran xiaolongran@tencent.com
Motivation
In #775 and #776, we support the error information that may occur when the Go SDK side processes the Ack Command, but there is a bug in this implementation. We do not wait for the error information to return directly, so the error obtained in the Ack interface will always be nil.
Modifications
doneCh
to wait for the information of ack error to return