Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue 733] Fix using closed connection in producer/consumer. #760

Closed

Conversation

sunby
Copy link

@sunby sunby commented Apr 19, 2022

Fixes #733

Motivation

See issue #733

Modifications

Return error if connection is closed.
The modification of consumer is the same as producer.

Verifying this change

  • Make sure that the change passes the CI checks.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)

Documentation

  • Does this pull request introduce a new feature? ( no)

Copy link
Contributor

@liangyuanpeng liangyuanpeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you provide some code for reproduce it? I have tested consumer and it is always working.

@sunby
Copy link
Author

sunby commented Apr 20, 2022

Can you provide some code for reproduce it? I have tested consumer and it is always working.

It's not stable to reproduce but I will have a try.

@lhotari
Copy link
Member

lhotari commented May 2, 2022

@sunby Please resolve the conflict in this PR by rebasing the changes (or merging master to PR branch).

@lhotari
Copy link
Member

lhotari commented May 2, 2022

It seems that #761 contains a similar change. @sunby can you check that?

@wolfstudy
Copy link
Member

It seems that #761 contains a similar change. @sunby can you check that?

Yes, #761 has already dealt with this problem, I will close this pr first, if #761 cannot fix the current problem, please reopen this pr at any time.

@wolfstudy wolfstudy closed this May 6, 2022
@sunby
Copy link
Author

sunby commented Sep 14, 2022

It seems that #761 contains a similar change. @sunby can you check that?

Yes, #761 has already dealt with this problem, I will close this pr first, if #761 cannot fix the current problem, please reopen this pr at any time.

Thanks for this fix! Does the AddConsumeHandler have the same issue with RegisterListener?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Producer can not reconnect to broker after server restart
4 participants