Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reconnection logic when topic is deleted #627

Merged
merged 2 commits into from
Sep 29, 2021

Conversation

wolfstudy
Copy link
Member

Signed-off-by: xiaolongran xiaolongran@tencent.com

Fixes #623

Motivation

As #623 said, when the topic is deleted forced, we don't should trying to reconnect, instead of giving up reconnection.

Modifications

  • Fix prodcuer reconnetion logic
  • Fix consumer reconnection logic

Signed-off-by: xiaolongran <xiaolongran@tencent.com>
@wolfstudy
Copy link
Member Author

image
This is the effect after the repair. When receiving the TopicNotFound error, we should jump out of the reconnection cycle, wait for sendTimeout, and automatically close the current producer process

Signed-off-by: xiaolongran <xiaolongran@tencent.com>
@wolfstudy wolfstudy self-assigned this Sep 29, 2021
@wolfstudy wolfstudy requested review from merlimat, cckellogg, freeznet and zymap and removed request for merlimat September 29, 2021 06:43
@wolfstudy wolfstudy added this to the 0.7.0 milestone Sep 29, 2021
@zymap zymap merged commit fafa8c3 into apache:master Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When topic is deleted forced, don't to tigger reconnect logic
2 participants