Logging what really caused lookup failure #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
reviewed
Jan 25, 2021
pulsar/internal/lookup_service.go
Outdated
| } | ||
| ls.log.Warnf("Failed to lookup topic: %s, error msg: %s", topic, errorMsg) | ||
| return nil, fmt.Errorf("failed to lookup topic: %s", errorMsg) | ||
| err := fmt.Errorf("failed to lookup topic: %s, error: %s, message: %s", topic, lr.GetError(), lr.GetMessage()) |
There was a problem hiding this comment.
We should preferably use the WithField("error", lr.getGetError()) instead of formatting into a string
There was a problem hiding this comment.
Thanks for review, I'll follow this convention
Now I removed string formatting, message fields will be highlight in log and only print once
merlimat
approved these changes
Jan 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Clusters deployed over k8s, during broker pod restarting / terminating, it's service DNS
.cluster.localwill be removed, cause proxy can't resolve the restarting owner broker DNS name.For now, client only logging
ServiceNotReadyerror but without details which help troubleshoot.Modifications
Logging LookupResponse failure detail message, like this:
Verifying this change