Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[issue 438] reader.HasNext() returns true on empty topic #441

Merged
merged 1 commit into from
Jan 15, 2021
Merged

[issue 438] reader.HasNext() returns true on empty topic #441

merged 1 commit into from
Jan 15, 2021

Conversation

zzzming
Copy link
Contributor

@zzzming zzzming commented Jan 15, 2021

Master Issue: #438 #438

Motivation

Fix issue #438

Reader.HasNext() should return true on empty topic, leading to hangs.

Modifications

It checks the last message on the broker with a valid Entry Id (non-negative).

Verifying this change

Add a new test case for read.erHasNext() when the topic is empty. The test case is part of CI now.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): no
  • The public API: no
  • The schema: no
  • The default values of configurations: no
  • The wire protocol: no

Documentation

  • Does this pull request introduce a new feature? no

@merlimat merlimat added this to the 0.4.0 milestone Jan 15, 2021
@merlimat merlimat merged commit 2456729 into apache:master Jan 15, 2021
@zzzming zzzming deleted the readerHasNext branch January 25, 2021 15:27
@flowchartsman flowchartsman mentioned this pull request Oct 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merlimat merlimat merlimat approved these changes

Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@zzzming @merlimat