[PR366] Make sure reconnectToBroker invoked before tearing down connection #373
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<--
Contribution Checklist
Master Issue: #366
Motivation
We have seen consumer hanging issues reported similar to #366
Consumer was unable to reconnect to broker under these conditions
As @jiazhai pointed that partition consumer's reconnectToBroker() may have never been invoked due to deadlock of closed Connection. This is described at the end of PR 366 comments.
Modifications
Reorganize the code to ensure consumer and producer handlers are closed before the connection is torn down, so that broker reconnect mechanism can run independently to retry until successful or reach the retry limit.
Verifying this change
This change is already covered by existing tests, such as (please describe tests).
Does this pull request potentially affect one of the following parts:
Documentation
This is not a feature but a bug fix.