Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support specified the oauth2 private key with prefix 'file://' and 'data://' #343

Merged
merged 1 commit into from
Aug 17, 2020

Conversation

zymap
Copy link
Member

@zymap zymap commented Aug 4, 2020


Motivation

Make the oauth2 read the private key can handle with 'file://' schema and 'data://' schema.

…ata://'

---

Master Issue: #<xyz>

*Motivation*

Make the oauth2 read the private key can handle with  'file://' schema and 'data://' schema.
Copy link
Member

@sijie sijie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zymap overall looks good. Can we add a test case for it?

@sijie sijie added this to the 0.2.0 milestone Aug 4, 2020
@zymap
Copy link
Member Author

zymap commented Aug 5, 2020

I added the new test case here: https://github.com/apache/pulsar-client-go/pull/343/files#diff-7e18f94aa1cb5bdae4886ab8052f0c14R107. Also I added the data:// schema test case.

Copy link
Member

@wolfstudy wolfstudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1 thanks @zymap work for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants