[producer] Fix producer goroutine leak #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per Producer there is a goroutine leaked. The goroutine is used for the partition auto-discovery and will never exit. This changes the goroutine to be properly exiting after a Close() on the producer.
simonswine
force-pushed
the
producer-go-routine-leak
branch
from
1c0e10c
to
145f79b
Compare
wolfstudy
approved these changes
Jul 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Per Producer there is a goroutine leaked. The goroutine is used for the partition auto-discovery and will never exit.
Modifications
This changes the goroutine to be properly exiting after a
Close()on the producer.Verifying this change
pprof output no longer shows running goroutines from the producer.
Worth considering: Testing for goroutine leaks using https://github.com/uber-go/goleak