Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes go.mod issue with invalid version #330

Merged
merged 1 commit into from
Jul 23, 2020
Merged

Fixes go.mod issue with invalid version #330

merged 1 commit into from
Jul 23, 2020

Conversation

simonswine
Copy link
Contributor

@simonswine simonswine commented Jul 23, 2020 •
edited
Loading

This fixes an issue with the latest master's go.mod

go get github.com/apache/pulsar-client-go/pulsar@master
go: found github.com/apache/pulsar-client-go/pulsar in github.com/apache/pulsar-client-go v0.1.2-0.20200715083626-b9f8c5cedefb
go: github.com/apache/pulsar-client-go master => v0.1.2-0.20200715083626-b9f8c5cedefb
go get: github.com/apache/pulsar-client-go@v0.1.2-0.20200715083626-b9f8c5cedefb requires
        github.com/apache/pulsar-client-go/oauth2@v0.0.0-00010101000000-000000000000: invalid version: unknown revision 000000000000

Modifications

Remove the "invalid version" and readded it

@simonswine simonswine changed the title ### Motivation Fixes go.mod issue with invalid version Jul 23, 2020
@wolfstudy wolfstudy added this to the 0.2.0 milestone Jul 23, 2020
@wolfstudy
Copy link
Member

@zymap PTAL thanks

zymap
zymap approved these changes Jul 23, 2020
View reviewed changes
Copy link
Member

@zymap zymap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wolfstudy wolfstudy merged commit 1f212f5 into apache:master Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolfstudy wolfstudy wolfstudy approved these changes

@zymap zymap zymap approved these changes

@merlimat merlimat Awaiting requested review from merlimat

Assignees

@simonswine simonswine

Labels
None yet
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@simonswine @wolfstudy @zymap