Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skip debug print out when batch disabled with no messages #261

Merged
merged 1 commit into from
May 23, 2020
Merged

skip debug print out when batch disabled with no messages #261

merged 1 commit into from
May 23, 2020

Conversation

zzzming
Copy link
Contributor

@zzzming zzzming commented May 22, 2020

This is a simple fix to tune down an excessive number of debug messages from "BatchBuilder flush: messages: " when producing messages with log level is set to debug. The log file would fill with "BatchBuilder flush: messages: 0" especially when DisableBatching : true and producing a low message rate.

@wolfstudy wolfstudy self-requested a review May 23, 2020 08:10
@wolfstudy wolfstudy removed their assignment May 23, 2020
@wolfstudy wolfstudy added this to the 0.1.1 milestone May 23, 2020
wolfstudy
wolfstudy approved these changes May 23, 2020
View reviewed changes
Copy link
Member

@wolfstudy wolfstudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

@wolfstudy wolfstudy merged commit e31d474 into apache:master May 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolfstudy wolfstudy wolfstudy approved these changes

Assignees

@zzzming zzzming

Labels
None yet
Projects
None yet
Milestone
0.1.1
Development

Successfully merging this pull request may close these issues.
2 participants
@zzzming @wolfstudy