fix dynamic config #1228
Merged
fix dynamic config #1228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -112,3 +112,8 @@ func (c *pulsarClient) endpoint(componentPath string, parts ...string) string { | |||
| path.Join(escapedParts...), | |||
| ) | |||
| } | |||
|
|
|||
| // this function won't do any escaping | |||
| func (c *pulsarClient) endpointWithFullPath(componentPath string, fullPath string) string { | |||
There was a problem hiding this comment.
Can we add some tests to cover this fix?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If users use a custom dynamic configuration, it's better not to do any escaping for the config value. Let the user fill it out manually.
The original implementation will escape the value twice, the first time is here:
pulsar-client-go/pulsaradmin/pkg/admin/brokers.go
Line 123 in a1ce5e6
the second time is here:
pulsar-client-go/pulsaradmin/pkg/admin/admin.go
Lines 107 to 109 in a1ce5e6