-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Talk about send
interface logic
#31
Labels
Milestone
Comments
👍 SGTM. It was a frequently requested feature on the C++ based Go client. |
We should do this before stabilizing the API |
seems already get a conclusion. would like to close this issue |
tisonkun
pushed a commit
to tisonkun/pulsar-client-go
that referenced
this issue
Aug 15, 2023
tisonkun
pushed a commit
to tisonkun/pulsar-client-go
that referenced
this issue
Aug 15, 2023
tisonkun
pushed a commit
that referenced
this issue
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
In
Producer
interface,Send
is defined as follows:In fact, when the pulsar client receives the
sendReceipt
, we don't assign a value to theProducerMessage
. The returned value is always nil.Describe the solution you'd like
We can define the interface as follows:
This way, on the one hand, it can be consistent with the Java client in the interface definition. On the other hand, we only need the msgID field. In this regard, if there is a place that is not considered comprehensive, please correct me.
The text was updated successfully, but these errors were encountered: