[BUG] TableView with JSONSchema returns incorrect type in Get

[ojcm]

Expected behavior

Using a TableView with a JSONSchema, the Get method should return a instance of the Go type provided via the TableViewOptions.SchemaValueType field.

Actual behavior

The type returned from the Get method is map[string]interface{} (and I presume it could also be []interface{}, string, float64, bool or nil depending on the raw JSON).

Steps to reproduce

The following test reproduces the issue, where exampleSchemaDef, testJSON, lookupURL and newTopicName are defined in the pulsar package test files.

func TestTableViewJSONSchema(t *testing.T) {
	var (
		schema = NewJSONSchema(exampleSchemaDef, nil)
		key    = "testKey"
		value  = testJSON{ID: 1, Name: "Pulsar"}
	)

	client, err := NewClient(ClientOptions{
		URL: lookupURL,
	})

	assert.NoError(t, err)
	defer client.Close()

	topic := newTopicName()

	producer, err := client.CreateProducer(ProducerOptions{
		Topic:  topic,
		Schema: schema,
	})
	assert.NoError(t, err)
	defer producer.Close()

	_, err = producer.Send(context.Background(), &ProducerMessage{
		Key:   key,
		Value: value,
	})
	assert.NoError(t, err)

	tv, err := client.CreateTableView(TableViewOptions{
		Topic:           topic,
		Schema:          schema,
		SchemaValueType: reflect.TypeOf(value),
	})
	assert.NoError(t, err)
	defer tv.Close()

	gotValue := tv.Get(key)
	// The following checks fail because `gotValue` has type map[string]interface{}
	assert.IsType(t, value, gotValue)
	assert.Equal(t, value, gotValue)
}

System configuration

Pulsar version: 3.1.0

[ojcm]

I believe I have a fix for this. Once it has been reviewed by my colleagues I'll open a PR in this repo. I expect that will be later today or tomorrow.

[RobertIndie]

@ojcm Thanks. I assign this issue to you.