Add watermark for dedup TTL #14137
Open
Add watermark for dedup TTL #14137
+178
−97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #14137 +/- ##
============================================
- Coverage 61.75% 55.74% -6.01%
- Complexity 207 796 +589
============================================
Files 2436 2048 -388
Lines 133233 108335 -24898
Branches 20636 17185 -3451
============================================
- Hits 82274 60394 -21880
+ Misses 44911 43138 -1773
+ Partials 6048 4803 -1245
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
deepthi912
reviewed
Oct 1, 2024
...al/src/main/java/org/apache/pinot/segment/local/dedup/BasePartitionDedupMetadataManager.java
Show resolved
Hide resolved
deepthi912
reviewed
Oct 1, 2024
...al/src/main/java/org/apache/pinot/segment/local/dedup/BasePartitionDedupMetadataManager.java
Outdated
Show resolved
Hide resolved
deepthi912
reviewed
Oct 1, 2024
...al/src/main/java/org/apache/pinot/segment/local/dedup/BasePartitionDedupMetadataManager.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dedup feature has TTL but it didn't store/load TTL watermark as done in upsert feature, so this PR adds this, to avoid the waste of adding stale dedup metadata into store when loading segments.