Update list of collaborators #14086
Merged
Update list of collaborators #14086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
yashmayya
commented
Sep 26, 2024
•
yashmayya
commented
- The collaborator list was initially added a few months ago in Add list of collaborators to asf.yaml #13346.
- The list needs to be periodically updated (every release or so) to take into account changes in contribution activity as well as existing collaborators becoming committers.
- The new list was generated with the same method used previously:
- Committers were manually filtered out from the above list (using the source of truth here - https://projects.apache.org/committee.html?pinot)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #14086 +/- ##
============================================
+ Coverage 61.75% 63.99% +2.24%
- Complexity 207 1536 +1329
============================================
Files 2436 2596 +160
Lines 133233 143295 +10062
Branches 20636 21948 +1312
============================================
+ Hits 82274 91702 +9428
+ Misses 44911 44846 -65
- Partials 6048 6747 +699
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
gortiz
reviewed
Sep 26, 2024
| @@ -31,12 +31,12 @@ github: | |||
| rebase: false | |||
| collaborators: | |||
| - sullis | |||
| - shenyu0127 | |||
| - tibrewalpratik17 | |||
| - yashmayya | |||
There was a problem hiding this comment.
I guess you used some kind of script to generate this list. Can you sort the list in alphabetical order? that would make it easier to actually understand who gets added and who gets removed.
There was a problem hiding this comment.
It's sorted in order of # of commits in the past year (from the output of git shortlog --numbered --summary --since="1 year ago").
Jackie-Jiang
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.