test the checking logic of whether segment preloading is enabled for upsert table #14085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tibrewalpratik17
approved these changes
Sep 25, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #14085 +/- ##
============================================
+ Coverage 61.75% 63.97% +2.22%
- Complexity 207 1538 +1331
============================================
Files 2436 2596 +160
Lines 133233 143295 +10062
Branches 20636 21948 +1312
============================================
+ Hits 82274 91679 +9405
+ Misses 44911 44872 -39
- Partials 6048 6744 +696
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a test on the checking logic of whether segment preloading is enabled for upsert table.
There was a bug in 1.2.0 that preloading was not disabled when there was no threads for preloading, as raised up by issue: #14067. The bug got fixed by #13747 but it's better to add a test case to keep checking on this.