refactor(core)!: Add observe layer as building block #5064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xuanwo <github@xuanwo.io>
Xuanwo
changed the title
Xuanwo
changed the title
Xuanwo
changed the title
|
Hi, @koushiro. Would you like to continue this work and migrate it to the I believe we can address the existing problems at the same time. |
Yeah, I'd like to. BTW, maybe the related issue link that you mentioned in the description is wrong? |
PsiACE
approved these changes
Aug 28, 2024
This was referenced Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Related to #5049
Rationale for this change
What changes are included in this PR?
Add a new mod called
opendal::layers::observe. In which we will provide:observe::MetricsIntercept: A trait that users can implement metrics intercept.observe::MetricsLayer: A layer that based onMetricsIntercept.Based on
observemod, all our existing metrics related crates can implement:MetricsLayer = observe::MetricsLayer<MetricsInterceptor>PrometheusClientLayer = observe::MetricsLayer<PrometheusClientInterceptor>PrometheusLayer = observe::MetricsLayer<PrometheusInterceptor>All of them will share the exactly same behavior. Users only need to configure the
Interceptordirectly.Are there any user-facing changes?
API Breaking Changes