-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmake(bugfix): sync CMake SIM Toolchain file #13669
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: xuxin19 <xuxin19@xiaomi.com>
-U_WIN32 will cause windows host source such as sim_hostirq.c hearder windows.h exception Signed-off-by: xuxin19 <xuxin19@xiaomi.com>
[Experimental Bot, please feedback here] No, this PR does not fully meet the NuttX requirements. Here's why and how to improve it:
Example Improvements Summary:
Impact:
Testing:
|
-U__linux__ | ||
-U__sun__ | ||
-U__unix__ | ||
-U__ENVIRONMENT_MAC_OS_X_VERSION_MIN_REQUIRED__) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anchao OK, let's unify the SIM option into Toolchain file and remove setting in SIM arch cmakelists.txt
Summary
Impact
Synchronous build system, not a new feature
Testing
All sim build