Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[TEST] Add microbenchmark for FC + add fusion #20780

Merged
merged 1 commit into from
Dec 23, 2021

Conversation

anko-intel
Copy link
Contributor

@anko-intel anko-intel commented Dec 17, 2021

Description

Add microbenchmark for Fully Connected with add fusion
and utility scripts to run it with proper OMP parameters set and check performance against different number of threads

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)

Comments

Examples of test output:

  • ./run.sh fc_add.py

elemwise_add, float

Shape Hidden Mean [ms]
( 1, 224) 512 0.236
( 1, 224) 4096 0.227
( 16,1024) 1024 0.337
( 32,4096) 1024 0.530
( 32,4096) 4096 1.539
( 512, 512) 4096 0.956

npi_add, float

Shape Hidden Mean [ms]
( 1, 224) 512 0.165
( 1, 224) 4096 0.164
( 16,1024) 1024 0.286
( 32,4096) 1024 0.523
( 32,4096) 4096 1.444
( 512, 512) 4096 0.846

elemwise_add, mode = smart, granularity = tensor-wise

Shape Hidden Mean [ms]
( 1, 224) 512 0.240
( 1, 224) 4096 0.236
( 16,1024) 1024 0.330
( 32,4096) 1024 0.396
( 32,4096) 4096 0.541
( 512, 512) 4096 0.900
  • ./run_per_thread.sh 48 8 64 fc_add.py

NUM_THREADS = 48 56 64

elemwise_add, float

Shape Hidden Mean [ms] Mean [ms] Mean [ms]
( 1, 224) 512 0.204 0.214 0.244
( 1, 224) 4096 0.205 0.211 0.232
( 16,1024) 1024 0.307 0.321 0.346
( 32,4096) 1024 0.569 0.535 0.536
( 32,4096) 4096 2.028 1.796 1.531
( 512, 512) 4096 1.124 1.085 0.962

+ utils scripts to run it
@mxnet-bot
Copy link

Hey @anko-intel , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [centos-gpu, website, miscellaneous, edge, clang, windows-cpu, unix-gpu, sanity, unix-cpu, windows-gpu, centos-cpu]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Dec 17, 2021
@anko-intel
Copy link
Contributor Author

@mxnet-bot run ci [centos-gpu, windows-cpu, windows-cpu ]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [windows-cpu, centos-gpu]

@anko-intel
Copy link
Contributor Author

@mxnet-bot run ci [windows-gpu ]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [windows-gpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Dec 20, 2021
@anko-intel
Copy link
Contributor Author

@mxnet-bot run ci [centos-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [centos-gpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Dec 20, 2021
Copy link
Contributor

@bartekkuncer bartekkuncer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bgawrych bgawrych merged commit 9653ab4 into apache:master Dec 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants