Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[2.0] Split np_elemwise_broadcast_logic_op.cc #20580

Merged
merged 5 commits into from
Sep 20, 2021

Conversation

barry-jin
Copy link
Contributor

@barry-jin barry-jin commented Sep 14, 2021

Description

With more data types introduced in #20478, MXNet is vulnerable to out of memory errors in building process. The website building pipeline and some development have been blocked by this issue a lot:
https://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/restricted-website-build-master/activity

As suggested in #19688, this PR will adopt option2 in the proposed solution and split:
np_elemwise_broadcast_logic_op.cc into 8 separate files.
np_elemwise_broadcast_op.cc into 5 separate files.

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Sep 14, 2021
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Sep 14, 2021
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Sep 15, 2021
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Sep 15, 2021
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Sep 15, 2021
@barry-jin
Copy link
Contributor Author

@mxnet-bot run ci [unix-gpu, website]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [website, unix-gpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Sep 15, 2021
@leezu leezu merged commit 179e7db into apache:master Sep 20, 2021
@barry-jin barry-jin deleted the split_logic branch September 20, 2021 18:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants