Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[v1.9.x] Remove cpp-predict example due to licensing issues #20530

Merged

Conversation

josephevans
Copy link
Contributor

@josephevans josephevans commented Aug 17, 2021

This fixes #20515 - remove cpp example for image classification that is not compliant with Apache 2.0 license due to prior copyright.

This change removes the example from the release source archive.

@mxnet-bot
Copy link

Hey @josephevans , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [clang, unix-gpu, website, miscellaneous, sanity, centos-cpu, centos-gpu, windows-cpu, edge, windows-gpu, unix-cpu]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress pr-awaiting-review PR is waiting for code review and removed pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress labels Aug 17, 2021
@josephevans
Copy link
Contributor Author

@leezu @sandeep-krishnamurthy @szha Could you please review?

Copy link
Member

@szha szha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just delete the file from the release archive?

Good point, makes it much easier. Refactored PR.

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-awaiting-review PR is waiting for code review labels Aug 17, 2021
@josephevans
Copy link
Contributor Author

This fixes item 3 in #20475.

@mseth10 mseth10 added pr-awaiting-merge Review and CI is complete. Ready to Merge and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Aug 18, 2021
@sandeep-krishnamurthy sandeep-krishnamurthy merged commit 524be2f into apache:v1.9.x Aug 18, 2021
@josephevans josephevans mentioned this pull request Aug 18, 2021
josephevans added a commit to josephevans/mxnet that referenced this pull request Aug 18, 2021
Just remove image classification CPP example from source tarball. (apache#20530)
josephevans added a commit that referenced this pull request Aug 19, 2021
Just remove image classification CPP example from source tarball. (#20530)
KexinFeng pushed a commit to KexinFeng/incubator-mxnet that referenced this pull request Aug 27, 2021
Just remove image classification CPP example from source tarball. (apache#20530)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-merge Review and CI is complete. Ready to Merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants