Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[BACKPORT][v1.x] [PIP] update manifest to include lib_api.cc #19912

Merged
merged 1 commit into from
Feb 22, 2021
Merged

[BACKPORT][v1.x] [PIP] update manifest to include lib_api.cc #19912

merged 1 commit into from
Feb 22, 2021

Conversation

access2rohit
Copy link
Contributor

@access2rohit access2rohit commented Feb 17, 2021 •
edited
Loading

Description

Backport #19850 to v1.x. This is a part of effort #19911

Checklist

Essentials

  • Changes are complete (i.e. I finished coding on this PR)
  • Code is well-documented

@mxnet-bot
Copy link

Hey @access2rohit , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [clang, centos-cpu, windows-cpu, unix-cpu, unix-gpu, sanity, edge, website, windows-gpu, miscellaneous, centos-gpu]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@lanking520 lanking520 added the pr-awaiting-testing PR is reviewed and waiting CI build and test label Feb 17, 2021
@szha
[PIP] update manifest to include lib_api.cc (apache#19850)
1570096 
* update manifest to include lib_api.cc

Signed-off-by: Sheng Zha <zhasheng@amazon.com>

* add cc

Signed-off-by: Sheng Zha <zhasheng@amazon.com>

* fix lib_api.cc packaging

Signed-off-by: Sheng Zha <zhasheng@amazon.com>
@lanking520 lanking520 added pr-awaiting-review PR is waiting for code review and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Feb 18, 2021
@access2rohit access2rohit mentioned this pull request Feb 20, 2021
Closed
13 tasks
@access2rohit
Copy link
Contributor Author

@szha can you please review ?

@szha szha merged commit 01d78f5 into apache:v1.x Feb 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@josephevans josephevans josephevans approved these changes

@szha szha Awaiting requested review from szha szha is a code owner

Assignees
No one assigned
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@access2rohit @mxnet-bot @josephevans @szha @lanking520