Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[BUGFIX] fix #18936, #18937 #19878

Merged
merged 3 commits into from
Apr 30, 2021
Merged

[BUGFIX] fix #18936, #18937 #19878

merged 3 commits into from
Apr 30, 2021

Conversation

r3stl355
Copy link
Contributor

@r3stl355 r3stl355 commented Feb 10, 2021

Description

Fixes #18936 and #18937

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

A single change in 'pdf_op.h' fixes both issues

Comments

For some reason I'm also getting some empty commits (5bf4895 & 12107ed) included in the PR but those don't appear in my local repository and should've been part of already merged PR. Please ignore those as they don't really do anything.

@mxnet-bot
Copy link

Hey @r3stl355 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [sanity, centos-cpu, clang, windows-gpu, unix-gpu, miscellaneous, edge, website, unix-cpu, centos-gpu, windows-cpu]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Feb 10, 2021
@r3stl355
Copy link
Contributor Author

@mxnet-bot run ci [unix-cpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-cpu]

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Feb 10, 2021
@szha szha merged commit 6f4ac54 into apache:master Apr 30, 2021
@szha
Copy link
Member

szha commented Apr 30, 2021

@r3stl355 thanks for the fixes!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Floating point exception in mxnet.ndarray.op.random_pdf_dirichlet
5 participants