Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[v1.x] ONNX support adaptiveAveragePooling2D and update Softmax to support temperature #19736

Merged
merged 8 commits into from
Jan 19, 2021

Conversation

waytrue17
Copy link
Contributor

@waytrue17 waytrue17 commented Jan 8, 2021

Description

Support onnx conversion of _contrib_AdaptiveAvgPooling2D. Update onnx conversion of softmax to support temperature attribute.

Due to some incompatible issue of mx-onnx conversion, currently we only support the conversion when output_size==1. Pytorch has the similar implementation: pytorch/pytorch#9711.

By inspecting all models in gluon model zoo, 16 of them has _contrib_AdaptiveAvgPooling2D. Out of the 16 models, 7 models use output_size>1, which are not supported in this pr.
Unsupported models:
psp_resnet50_ade
psp_resnet101_ade
psp_resnet101_voc
psp_resnet101_citys
psp_resnet101_coco
icnet_resnet50_mhpv1
icnet_resnet50_citys

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@waytrue17 waytrue17 requested a review from szha as a code owner January 8, 2021 19:03
@mxnet-bot
Copy link

Hey @waytrue17 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [unix-cpu, centos-gpu, sanity, centos-cpu, windows-cpu, miscellaneous, website, clang, edge, windows-gpu, unix-gpu]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@lanking520 lanking520 added the pr-work-in-progress PR is still work in progress label Jan 8, 2021
@waytrue17 waytrue17 changed the title [WIP] ONNX support adaptiveAveragePooling2D [v1.x] ONNX support adaptiveAveragePooling2D Jan 8, 2021
@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jan 8, 2021
@waytrue17
Copy link
Contributor Author

@mxnet-bot run ci [unix-cpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-cpu]

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-work-in-progress PR is still work in progress labels Jan 14, 2021
@waytrue17 waytrue17 changed the title [v1.x] ONNX support adaptiveAveragePooling2D [v1.x] ONNX support adaptiveAveragePooling2D and update Softmax to support temperature Jan 14, 2021
@lanking520 lanking520 added pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress labels Jan 14, 2021
@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jan 15, 2021
@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-awaiting-review PR is waiting for code review labels Jan 15, 2021
@lanking520 lanking520 added pr-awaiting-review PR is waiting for code review and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jan 16, 2021
@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-awaiting-review PR is waiting for code review pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jan 16, 2021
@Zha0q1 Zha0q1 merged commit e8e4fcd into apache:v1.x Jan 19, 2021
@waytrue17 waytrue17 deleted the onnx branch January 19, 2021 19:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants