Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[v1.x] ONNX _contrib_interleaved_matmul_selfatt_valatt and LayerNorm #19661

Merged
merged 6 commits into from
Dec 17, 2020
Merged

[v1.x] ONNX _contrib_interleaved_matmul_selfatt_valatt and LayerNorm #19661

merged 6 commits into from
Dec 17, 2020

Conversation

waytrue17
Copy link
Contributor

@waytrue17 waytrue17 commented Dec 11, 2020 •
edited
Loading

Description

Support _contrib_interleaved_matmul_selfatt_valatt to ONNX, rewrite LayrNorm conversion.
Add tests for the ops

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

@waytrue17 waytrue17 requested a review from szha as a code owner December 11, 2020 19:18
@mxnet-bot
Copy link

Hey @waytrue17 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [website, miscellaneous, windows-gpu, windows-cpu, centos-gpu, clang, unix-gpu, unix-cpu, edge, centos-cpu, sanity]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@lanking520 lanking520 added the pr-awaiting-testing PR is reviewed and waiting CI build and test label Dec 11, 2020
@waytrue17 waytrue17 changed the title [v1.x] Support _contrib_interleaved_matmul_selfatt_valatt to ONNX [WIP] Support _contrib_interleaved_matmul_selfatt_valatt to ONNX Dec 11, 2020
@lanking520 lanking520 added pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Dec 11, 2020
Zha0q1
Zha0q1 approved these changes Dec 16, 2020
View reviewed changes
Copy link
Contributor

@Zha0q1 Zha0q1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@waytrue17 waytrue17 changed the title [WIP] Support _contrib_interleaved_matmul_selfatt_valatt to ONNX [WIP] ONNX _contrib_interleaved_matmul_selfatt_valatt and LayerNorm Dec 16, 2020
@Zha0q1 Zha0q1 merged commit f2ab4c9 into apache:v1.x Dec 17, 2020
@waytrue17 waytrue17 changed the title [WIP] ONNX _contrib_interleaved_matmul_selfatt_valatt and LayerNorm [v1.x] ONNX _contrib_interleaved_matmul_selfatt_valatt and LayerNorm Dec 17, 2020
@waytrue17 waytrue17 deleted the onnx branch December 17, 2020 19:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Zha0q1 Zha0q1 Zha0q1 approved these changes

@szha szha Awaiting requested review from szha szha is a code owner

Assignees
No one assigned
Labels
pr-work-in-progress PR is still work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@waytrue17 @mxnet-bot @Zha0q1 @lanking520