Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[v1.x] Backport extension bug fixes to v1.x (#19469) #19503

Merged
merged 3 commits into from
Nov 13, 2020
Merged

[v1.x] Backport extension bug fixes to v1.x (#19469) #19503

merged 3 commits into from
Nov 13, 2020

Conversation

samskalicky
Copy link
Contributor

@samskalicky samskalicky commented Nov 9, 2020 •
edited
Loading

Backport #19469, and added h5py version pinning to less than 3

@samskalicky
Extension bug fixes (apache#19469)
d8bb575 
* initial commit

* syntax fix

* spacing

* added test case
@mxnet-bot
Copy link

Hey @samskalicky , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [clang, unix-gpu, miscellaneous, centos-cpu, edge, sanity, windows-gpu, website, windows-cpu, centos-gpu, unix-cpu]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Nov 9, 2020
@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-work-in-progress PR is still work in progress labels Nov 11, 2020
@lanking520 lanking520 added pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress labels Nov 11, 2020
@samskalicky samskalicky added pr-awaiting-merge Review and CI is complete. Ready to Merge and removed pr-awaiting-review PR is waiting for code review labels Nov 11, 2020
@samskalicky samskalicky merged commit 6ca77dd into apache:v1.x Nov 13, 2020
josephevans pushed a commit to josephevans/mxnet that referenced this pull request Dec 8, 2020
@samskalicky
[v1.x] Backport extension bug fixes to v1.x (apache#19469) (apache#19503
959a668 
)

* Extension bug fixes (apache#19469)

* initial commit

* syntax fix

* spacing

* added test case

* fixed indentation

* h5py version pinned to <3
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@szha szha Awaiting requested review from szha szha is a code owner

@aaronmarkham aaronmarkham Awaiting requested review from aaronmarkham aaronmarkham is a code owner

@marcoabreu marcoabreu Awaiting requested review from marcoabreu marcoabreu is a code owner

Assignees
No one assigned
Labels
pr-awaiting-merge Review and CI is complete. Ready to Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samskalicky @mxnet-bot @lanking520