Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[1.x] Backport Enable Numpy support for Gluon Block optimize_for to v1.x #19456

Merged
merged 3 commits into from
Nov 5, 2020
Merged

[1.x] Backport Enable Numpy support for Gluon Block optimize_for to v1.x #19456

merged 3 commits into from
Nov 5, 2020

Conversation

samskalicky
Copy link
Contributor

@samskalicky samskalicky commented Oct 30, 2020 •
edited
Loading

Description

Backport #19455 and aligned h5py in other 2 places to match #19476

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@mxnet-bot
Copy link

Hey @samskalicky , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [centos-gpu, windows-cpu, unix-gpu, website, windows-gpu, centos-cpu, sanity, unix-cpu, clang, miscellaneous, edge]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 30, 2020
@leezu
Copy link
Contributor

leezu commented Oct 31, 2020

@mxnet-bot run ci [centos-cpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [centos-cpu]

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 31, 2020
@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-work-in-progress PR is still work in progress labels Nov 5, 2020
@samskalicky samskalicky mentioned this pull request Nov 5, 2020
Merged
@samskalicky
Copy link
Contributor Author

Thanks for the suggestion @leezu on pinning h5py!
https://github.com/apache/incubator-mxnet/pull/19456/files#diff-13df16405952f77a49f134926f12ecca92c6aabd777647710bee0c5e2d2994e7R33
I pinned it to match the other 2 places we pin it:
https://github.com/apache/incubator-mxnet/blob/15a88646bbfd70437d398add7958b49e3b9f3236/ci/docker/install/ubuntu_publish.sh#L84
https://github.com/apache/incubator-mxnet/blob/15a88646bbfd70437d398add7958b49e3b9f3236/ci/docker/install/requirements#L25

@lanking520 lanking520 added pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress labels Nov 5, 2020
@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-awaiting-review PR is waiting for code review labels Nov 5, 2020
@lanking520 lanking520 added pr-awaiting-merge Review and CI is complete. Ready to Merge and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Nov 5, 2020
@samskalicky samskalicky merged commit 87b66a9 into apache:v1.x Nov 5, 2020
josephevans pushed a commit to josephevans/mxnet that referenced this pull request Dec 8, 2020
@samskalicky
[1.x] Backport Enable Numpy support for Gluon Block optimize_for to v…
c1fab97 
…1.x (apache#19456)

* initial commit

* pinned h5py
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@leezu leezu leezu approved these changes

@szha szha Awaiting requested review from szha szha is a code owner

@aaronmarkham aaronmarkham Awaiting requested review from aaronmarkham aaronmarkham is a code owner

@marcoabreu marcoabreu Awaiting requested review from marcoabreu marcoabreu is a code owner

Assignees
No one assigned
Labels
pr-awaiting-merge Review and CI is complete. Ready to Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@samskalicky @mxnet-bot @leezu @lanking520