-
Notifications
You must be signed in to change notification settings - Fork 6.8k
[TEST] Added large tensor tests to verify support for split ops #19357
Conversation
Hey @access2rohit , Thanks for submitting the PR
CI supported jobs: [unix-gpu, sanity, clang, website, windows-cpu, miscellaneous, centos-cpu, unix-cpu, edge, centos-gpu, windows-gpu] Note: |
0516f1c
to
703868c
Compare
@mxnet-label-bot add [pr-awaiting-review] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left 1 comment, rest looks good! It looks like internally they share the same implementation SplitOpForwardImpl
|
||
@use_np | ||
def test_dsplit(): | ||
inp = np.arange(INT_OVERFLOW, dtype=np.int64).reshape(INT_OVERFLOW, 1, 1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use create_2d_np_tensor here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is 3d tensor. We don't have N-Dim function. Plus not too many cases where we need 3d tensor for testing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ohh ok that makes sense
Large tensor tests for
split
,hsplit
,vsplit
anddsplit
Description
(Brief description on what this PR is about)
Checklist
Essentials
Testing