Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[DOC] Add examples of running Python unittests to docs #19253

Merged
merged 2 commits into from
Oct 12, 2020

Conversation

r3stl355
Copy link
Contributor

@r3stl355 r3stl355 commented Sep 29, 2020

Description

Added an example of running Python tests in Conda environment

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

@mxnet-bot
Copy link

Hey @r3stl355 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [miscellaneous, windows-gpu, unix-cpu, edge, unix-gpu, website, clang, sanity, centos-cpu, windows-cpu, centos-gpu]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

Copy link
Contributor

@leezu leezu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we build MXNet outside of conda and use it inside conda, there can be toolchain mismatch issues causing segfault or deadlock. For example, this is known to happen when building mxnet-horovod with mpi. The reason appears to be a conflict between statically linked libraries in the conda python binary and binaries linked by the mpi integration. See dmlc/gluon-nlp#1371 for details.

As we don't have any instructions for building mxnet with the conda toolchain, how about updating this PR to be independent of conda?

@r3stl355
Copy link
Contributor Author

r3stl355 commented Sep 30, 2020

Sure, I'll remove conda

@leezu leezu marked this pull request as draft October 1, 2020 17:09
@r3stl355
Copy link
Contributor Author

r3stl355 commented Oct 3, 2020

run ci [macosx-x86_64]

@r3stl355 r3stl355 requested a review from leezu October 3, 2020 21:17
@r3stl355
Copy link
Contributor Author

r3stl355 commented Oct 3, 2020

run ci [centos-cpu,centos-gpu, unix-cpu]

@r3stl355
Copy link
Contributor Author

r3stl355 commented Oct 3, 2020

@mxnet-bot run ci [macosx-x86_64,centos-cpu,centos-gpu, unix-cpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [centos-cpu, centos-gpu, unix-cpu]

@leezu
Copy link
Contributor

leezu commented Oct 5, 2020

@mxnet-bot run ci [macosx-x86_64,centos-cpu,centos-gpu, unix-cpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [centos-gpu, unix-cpu, centos-cpu]

@leezu
Copy link
Contributor

leezu commented Oct 5, 2020

@mxnet-bot run ci [centos-cpu,centos-gpu, unix-cpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [centos-gpu, unix-cpu, centos-cpu]

@leezu leezu marked this pull request as ready for review October 5, 2020 16:58
@leezu
Copy link
Contributor

leezu commented Oct 5, 2020

@mxnet-bot run ci [edge]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [edge]

@szha szha merged commit 293fd9a into apache:master Oct 12, 2020
@szha
Copy link
Member

szha commented Oct 12, 2020

Many thanks for the contribution, Nikolay!

@r3stl355
Copy link
Contributor Author

Ahh, merged - thanks. I can now starting looking at something else

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants