Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[v1.8.x] Fix Nightly Large Tensor test #19215

Merged
merged 1 commit into from
Sep 24, 2020

Conversation

ChaiBapchya
Copy link
Contributor

CP #19194

Co-authored-by: Rohit Kumar Srivastava srivastava.141@buckeyemail.osu.edu

Co-authored-by: Rohit Kumar Srivastava srivastava.141@osu.edu
Co-authored-by: Rohit Kumar Srivastava srivastava.141@buckeyemail.osu.edu

Description

(Brief description on what this PR is about)

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

* fixing batch_norm and layer_norm for large tensors (apache#17805)

Co-authored-by: Rohit Kumar Srivastava <srivastava.141@buckeyemail.osu.edu>

* Fix nightly large_vector test caused by incorrect with_seed path (apache#18178)

* add back the missing environment function

Co-authored-by: Rohit Kumar Srivastava <srivastava.141@osu.edu>
Co-authored-by: Rohit Kumar Srivastava <srivastava.141@buckeyemail.osu.edu>
@mxnet-bot
Copy link

Hey @ChaiBapchya , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [centos-gpu, website, edge, unix-cpu, clang, sanity, miscellaneous, centos-cpu, unix-gpu, windows-cpu, windows-gpu]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@ChaiBapchya
Copy link
Contributor Author

@ChaiBapchya
Copy link
Contributor Author

@samskalicky @josephevans

@ChaiBapchya
Copy link
Contributor Author

1.x nightly is green. Good to merge this PR in 1.8.x

@samskalicky samskalicky merged commit 7c9046a into apache:v1.8.x Sep 24, 2020
@ChaiBapchya ChaiBapchya deleted the nightly_cp branch October 13, 2020 21:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants