Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[v1.8][Port PR] Port padding fix #19167

Merged
merged 1 commit into from
Sep 17, 2020
Merged

[v1.8][Port PR] Port padding fix #19167

merged 1 commit into from
Sep 17, 2020

Conversation

sxjscience
Copy link
Member

@sxjscience sxjscience commented Sep 17, 2020 •
edited
Loading

Description

Port pad fix PR: #19044

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@ryanwentaoxu @sxjscience
Fix the error of gradient of np.pad (apache#19044)
b0f8ea9 
* pad grad modified

* Fix pad grad error

* modify pad constant backward

* Fix test error

* Fix test error

* Fix kAddTo supported

* Add test for grad_req='add'

Co-authored-by: Xingjian Shi <xshiab@connect.ust.hk>
@mxnet-bot
Copy link

Hey @sxjscience , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [centos-gpu, unix-cpu, sanity, centos-cpu, unix-gpu, edge, website, clang, miscellaneous, windows-cpu, windows-gpu]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@sxjscience
Copy link
Member Author

@samskalicky Ported

@samskalicky samskalicky mentioned this pull request Sep 17, 2020
Open
@samskalicky samskalicky merged commit 039fef9 into apache:v1.x Sep 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sxjscience @mxnet-bot @samskalicky @ryanwentaoxu