Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[v1.x Backport] Fix softmax, logsoftmax failed on empty ndarray (#18602) #18708

Merged
merged 3 commits into from
Aug 3, 2020

Conversation

bgawrych
Copy link
Contributor

@bgawrych bgawrych commented Jul 14, 2020

Description

Backport of two changes:

Third commit "Fix softmax, logsoftmax backward failed on empty ndarray (#18710)" is not backported
directly from master branch because fix was covered by other PR improving unittests (#18694).

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@mxnet-bot
Copy link

Hey @bgawrych , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [windows-cpu, unix-gpu, windows-gpu, edge, centos-gpu, miscellaneous, website, sanity, unix-cpu, centos-cpu, clang]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@bgawrych
Copy link
Contributor Author

@mxnet-bot run ci [edge, unix-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [edge, unix-gpu]

@bgawrych
Copy link
Contributor Author

@mxnet-bot run ci [edge, unix-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [edge, unix-gpu]

@bgawrych
Copy link
Contributor Author

@TaoLv @PatricZhao Can you take a look?
CC: @Yiyan66 as owner of the fix npx.softmax for 0-sized inputs (#18158)

@TaoLv
Copy link
Member

TaoLv commented Jul 24, 2020

@bgawrych I'm rebasing your branch to the latest of v1.x.

@lanking520 lanking520 added the pr-awaiting-review PR is waiting for code review label Jul 26, 2020
@bgawrych
Copy link
Contributor Author

@mxnet-bot run ci [website]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [website]

@TaoLv
Copy link
Member

TaoLv commented Jul 28, 2020

Not sure what's the merge policy of v1.x. Github keeps saying this branch is out of date w ith the base branch so we cannot merge it.

@bgawrych
Copy link
Contributor Author

@mxnet-bot run ci [unix-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-gpu]

@bgawrych
Copy link
Contributor Author

@mxnet-bot run ci [unix-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-gpu]

@bgawrych
Copy link
Contributor Author

bgawrych commented Aug 3, 2020

@mxnet-bot run ci [all]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [edge, centos-gpu, sanity, unix-gpu, clang, centos-cpu, unix-cpu, miscellaneous, website, windows-gpu, windows-cpu]

@bgawrych
Copy link
Contributor Author

bgawrych commented Aug 3, 2020

@TaoLv @PatricZhao I think that the problem with out of date branch is solved

@TaoLv
Copy link
Member

TaoLv commented Aug 3, 2020

@bgawrych Thanks. Now it's merged.

@TaoLv TaoLv merged commit 73d3a7b into apache:v1.x Aug 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants