Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[CI][v1.6.x] Fix blocked pipelines [windows,unix-cpu,unix-gpu] on v1.6.x #17993

Merged
merged 6 commits into from
Apr 10, 2020

Conversation

ChaiBapchya
Copy link
Contributor

@ChaiBapchya ChaiBapchya commented Apr 7, 2020

Fixes following issues in the following pipelines

Fix setRefClass not found issue by adding import of library methods
Fixes #17920
[unix-cpu] - R: CPU
[unix-cpu] - R: MKLDNN-CPU
[unix-gpu] - R: GPU
[website] - R Docs

[website] - Jekyll website
rvm version error [fix by pinning the updated version 2.6.3]

[unix-cpu] - Tests / Python3: MKLDNN-MKL-CPU
test_quantize flaky test
Fix : cherrypick the commit from master that fixed this flakiness issue

[unix-gpu] - Static build GPU 14.04 Python
gnu_tls handshake failed [NVIDIA Docker no longer supported on Ubuntu 14.04 hence TLS / certificate issue upon apt-get update]
Fix : switch from https to http

@mxnet-bot
Copy link

Hey @ChaiBapchya , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [centos-gpu, unix-gpu, website, centos-cpu, sanity, windows-cpu, windows-gpu, unix-cpu, miscellaneous, edge, clang]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@ChaiBapchya
Copy link
Contributor Author

@mxnet-bot run ci [unix-cpu]

@ChaiBapchya ChaiBapchya changed the title fix R error; backport 1 line from #17228 [R][v1.6.x] Fix setRefClass function not found error Apr 8, 2020
@ChaiBapchya
Copy link
Contributor Author

Testing this locally, able to reproduce the docs error

Loading mxnet
[1] "Loading local: inst/libs/libmxnet.so"
<simpleError in find.package(package, lib.loc, verbose = verbose): there is no package called 'mxnet'
>
[1] "Loading local: src/mxnet.so"
<simpleError in find.package(package, lib.loc, verbose = verbose): there is no package called 'mxnet'
>
Error in loadModule("mxnet", TRUE) : could not find function "loadModule"
Calls: <Anonymous> ... load_code -> <Anonymous> -> run_pkg_hook -> <Anonymous>
Execution halted

However, upon checking the local files, both mxnet.so and libmxnet.so exist.
So dyn.load isn't able to find package

> ls R-package/inst/libs/
libmxnet.so
> ls R-package/src/
libmxnet.so

@ChaiBapchya
Copy link
Contributor Author

Cherrypicking Python2 -> Python3 related PRs I found after doing a git diff between v1.6.x branch and master
v1.6.x...ChaiBapchya:master

@ChaiBapchya ChaiBapchya changed the title [R][v1.6.x] Fix setRefClass function not found error [R][v1.6.x] Fix doc build issue on v1.6.x Apr 8, 2020
@ChaiBapchya ChaiBapchya mentioned this pull request Apr 9, 2020
7 tasks
@ChaiBapchya
Copy link
Contributor Author

@mxnet-bot run ci [unix-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-gpu]

@ChaiBapchya
Copy link
Contributor Author

So as it turns out, it wasn't needed to cherrypick previous PRs.
Because even without migrating CI from Py2 to Py3 docs test pass
@aaronmarkham @leezu @aaronmarkham
Plz review/merge. Thanks.

@ChaiBapchya
Copy link
Contributor Author

ChaiBapchya commented Apr 9, 2020

@lanking520 @zachgk any idea about the Scala failure? http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/mxnet-validation%2Funix-cpu/detail/PR-17993/4/pipeline

Since this is a network issue, generally gets resolved by retriggering the build.

Looking into the Static build 14.04 Python unix-gpu failure : it fails at apt-get update in ubuntu_publish.sh
it is on ubuntu 14.04 with nvidia-docker.
Surprisingly, master branch doesn't fail. Nor do previous commits in 1.6 branch.

@ChaiBapchya
Copy link
Contributor Author

@mxnet-bot run ci [unix-cpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-cpu]

@ChaiBapchya
Copy link
Contributor Author

Fixes #18005

@ChaiBapchya
Copy link
Contributor Author

It's weird why 1.6 branch is facing rvm version error.
All the previous 5 builds had passed for Jekyll build.

@ChaiBapchya
Copy link
Contributor Author

@mxnet-bot run ci [unix-cpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-cpu]

@zixuanweeei
Copy link
Contributor

Just a reminder: #11747 (comment)

@ChaiBapchya ChaiBapchya changed the title [R][v1.6.x] Fix doc build issue on v1.6.x [R][v1.6.x] Fix blocked pipelines [windows,unix-cpu,unix-gpu] on v1.6.x Apr 10, 2020
@ChaiBapchya
Copy link
Contributor Author

@mxnet-label-bot add [pr-awaiting-review]

@lanking520 lanking520 added the pr-awaiting-review PR is waiting for code review label Apr 10, 2020
@ChaiBapchya
Copy link
Contributor Author

@leezu leezu merged commit 3ba1751 into apache:v1.6.x Apr 10, 2020
@ChaiBapchya ChaiBapchya deleted the backport_R_fix branch April 10, 2020 17:16
@ChaiBapchya ChaiBapchya changed the title [R][v1.6.x] Fix blocked pipelines [windows,unix-cpu,unix-gpu] on v1.6.x [CI][v1.6.x] Fix blocked pipelines [windows,unix-cpu,unix-gpu] on v1.6.x Jun 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants