Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MWRAPPER-108] - only-mvnw add error checking when download or unpacking fails #98

Closed
wants to merge 1 commit into from

Conversation

selckin
Copy link

@selckin selckin commented Apr 20, 2023

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MWRAPPER-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MWRAPPER-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@selckin selckin changed the title only-mvnw add error checking when download or unpacking fails [MWRAPPER-108] - only-mvnw add error checking when download or unpacking fails Apr 20, 2023
@bdemers
Copy link
Member

bdemers commented Mar 20, 2024

I just ran into the same problem while testing out the wrapper and mvnd I didn't set the version correctly I had a silent death.
This patch seemed to work fine and produced a reasonable error:

mvnw: Failed to fetch https://archive.apache.org/dist/maven/mvnd/1.0-m8/maven-mvnd-1.0-m8-darwin-aarch64.zip

(My version should have been 1.0-m8-m39)

@selckin I know this has been sitting a while, but do you want rebase? (I would have done it but I didn't want to push changes to your master branch)

Copy link
Member

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not?

@cstamas
Copy link
Member

cstamas commented Apr 17, 2024

Superseded by #130

@cstamas cstamas closed this Apr 17, 2024
cstamas added a commit that referenced this pull request Apr 17, 2024
…130)

Script silently just failed. Reused changes from dead PR #98 w/ help of @michael-o 👍  Thanks both!

---

https://issues.apache.org/jira/browse/MWRAPPER-108
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants