Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MSHARED-860] deprecated Windows 9X CommandShell #20

Merged
merged 4 commits into from
Mar 12, 2020
Merged

[MSHARED-860] deprecated Windows 9X CommandShell #20

merged 4 commits into from
Mar 12, 2020

Conversation

elharo
Copy link
Contributor

@elharo elharo commented Mar 8, 2020

@elharo elharo requested a review from michael-o March 8, 2020 18:53
michael-o
michael-o approved these changes Mar 8, 2020
View reviewed changes
src/main/java/org/apache/maven/shared/utils/cli/shell/Shell.java Outdated
@@ -29,12 +29,11 @@
/**
* <p>
* Class that abstracts the Shell functionality,
* with subclases for shells that behave particularly, like
* with subclasses for shells that behave particularly, like</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Javadoc 8 will probably bug you for this. They expect <p> only.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

michael-o
michael-o requested changes Mar 8, 2020
View reviewed changes
src/main/java/org/apache/maven/shared/utils/cli/shell/CmdShell.java Outdated
@@ -24,7 +24,7 @@

/**
* <p>
* Implementation to call the CMD Shell present on Windows NT, 2000 and XP
* Implementation to call the CMD Shell present on Windows NT, 2000, X, 7, and 10.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

X => XP
As well as Windows 8

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

src/main/java/org/apache/maven/shared/utils/cli/shell/CommandShell.java Outdated
@@ -26,8 +26,9 @@
* </p>
*
* @author <a href="mailto:carlos@apache.org">Carlos Sanchez</a>
*
* @deprecated Windows Me is long dead. Update to Windows 10 and use {@link CmdShell}.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was Windows ME. Horrible OS.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@elharo elharo merged commit cb448b9 into master Mar 12, 2020
@elharo elharo deleted the winme branch March 12, 2020 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-o michael-o michael-o approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elharo @michael-o