1.0.3 modified api #1004
Merged
1.0.3 modified api #1004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in one file
in datasourcemanager package
casionone
reviewed
Sep 16, 2021
| return Message.ok().data("update_id", envId); | ||
| } | ||
|
|
||
| @RequestMapping(value = "/env/{env_id}/form",method = RequestMethod.PUT,headers = MediaType.MULTIPART_FORM_DATA) |
There was a problem hiding this comment.
heders or consumes?
javas.ws.rs.core.MediaType can be replaced by org.springframework.http.MediaType
casionone
reviewed
Sep 16, 2021
| @POST | ||
| @Path("/env/json") | ||
| public Response insertJsonEnv(DataSourceEnv dataSourceEnv, @Context HttpServletRequest req){ | ||
| return RestfulApiHelper.doAndResponse(()->{ |
There was a problem hiding this comment.
About RestfulApiHelper.doAndResponse
may be modify RestfulApiHelper.doAndResponse return object of Response to Message will be better
in datasourcemanager package
|
casionone
approved these changes
Sep 17, 2021
casionone
approved these changes
Sep 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
it can transform jersey to spring mvc api
Brief change log
remove jersey api
add spring mvc api
imcomplete part
but i can not transform requestbody in jersey to spring mvc .
just like FormDataMultiPart multiPartForm in RequestBody