Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update thrift to 0.15.0 to fit IoTDB 0.13.0 #41

Merged
merged 2 commits into from
Jul 22, 2022

Conversation

citrusreticulata
Copy link
Contributor

===update thrift to 0.15.0===

  1. replace "NewTFramedTransport" with "NewTFramedTransportConf", and use default config for this function.

2.fix function "NewTSocketConf"

3.replace deprecated func "NewTFramedTransport"

p.s.
in thrift 0.14.1, func NewTSocketConf returns two values;
in thrift 0.15.0, func NewTSocketConf just returns one.

===update readme and makefile to fit thrift 0.15.0===

update README.md and README_ZH.md,update makefile

1. replace "NewTFramedTransport" with "NewTFramedTransportConf", and use default conf for this function.

2.fix function "NewTSocketConf"

3.replace deprecated func "NewTFramedTransport"

p.s.
in thrift 0.14.1, func NewTSocketConf returns two values;
in thrift 0.15.0, func NewTSocketConf just returns one.
update readme and makefile to fit thrift 0.15.0
@citrusreticulata
Copy link
Contributor Author

Please pay attention to difference of thrift version between go-client front and IoTDB backend.
That means go-client depends on thrift 0.15.0 in this PR, while IoTDB(0.13.x) depends on thrift 0.14.1.
Therefore, "rpc.go" and other files corresponding thrift files are version 0.14.1.
But there is no problem in network connection yet. The two versions of connection are compatible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants