Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ChartPlugin and metadata for nvd3 and BigNumber vis #6085

Merged
merged 4 commits into from
Oct 12, 2018
Merged

Add ChartPlugin and metadata for nvd3 and BigNumber vis #6085

merged 4 commits into from
Oct 12, 2018

Conversation

kristw
Copy link
Contributor

@kristw kristw commented Oct 12, 2018

  • Define metadata and ChartPlugin for nvd3 and BigNumber charts.
  • Copy thumbnail images to visualization directories and refer to them in metadata.

(similar process with #6072)

@williaster @conglei @graceguo-supercat @michellethomas

@kristw kristw closed this Oct 12, 2018
@kristw kristw reopened this Oct 12, 2018
@kristw kristw closed this Oct 12, 2018
@kristw kristw reopened this Oct 12, 2018
williaster
williaster approved these changes Oct 12, 2018
View reviewed changes
Copy link
Contributor

@williaster williaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

one question I had was why the large thumbnails are necessary since they aren't referenced anywhere?

@kristw kristw mentioned this pull request Oct 12, 2018
Merged
@kristw
Copy link
Contributor Author

kristw commented Oct 12, 2018

re: large thumbnails.
They are in the assets/images directory.
After all plugin conversion is done I want to remove both viz_thumbnails and viz_thumbnails_large directories. The large one is currently not referenced in js but might be referenced in markdown documentation.

@williaster williaster merged commit 8e88d02 into apache:master Oct 12, 2018
@kristw kristw deleted the kristw-nvd3-meta branch October 12, 2018 19:13
@kristw kristw mentioned this pull request Oct 12, 2018
Merged
bipinsoniguavus pushed a commit to ThalesGroup/incubator-superset that referenced this pull request Dec 26, 2018
@kristw @bipinsoniguavus
Add ChartPlugin and metadata for nvd3 and BigNumber vis (apache#6085)
c8706b1 
* add nvd3 thumbnails

* add ChartPlugin and metadata files

* add BigNumber thumbnails

* Add bignumber ChartPlugin
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@williaster williaster williaster approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kristw @williaster @mistercrunch